John E. Malmberg wrote:
On VMS, if the $Config{make} is either MMK or MMS, then the makefile is 'DESCRIP.MMS'.

Currently on VMS it is believed that $Config{make} is always one of those two, however I hope to change that in the future.

With this change and the others, 20_CPANPLUS-Dist-MM.t passes all tests.

However 06_CPANPLUS-Internals-Constants.t also needs a corresponding patch as it is checking the name of the build procedure returned.

-John
[EMAIL PROTECTED]
Personal Opinion Only
--- /rsync_root/perl/lib/CPANPLUS/t/06_CPANPLUS-Internals-Constants.t   Tue Apr 
10 02:43:20 2007
+++ lib/CPANPLUS/t/06_CPANPLUS-Internals-Constants.t    Tue Sep  4 00:36:35 2007
@@ -49,6 +49,13 @@
         BUILD_PL    => 'Build.PL',
         BLIB        => 'blib',
     };
+
+    # if VMS && MMK/MMS then DESCRIP.MMS
+    if (($^O eq 'VMS') &&
+        ($Config::Config{make} =~ /MM[S|K]/i)) {
+        $tmpl->{MAKEFILE} = 'DESCRIP.MMS';
+    }
+
     
     while ( my($sub,$res) = each %$tmpl ) {
         is( &{$sub}->(), $res, "$sub returns proper result without args" );
--- /rsync_root/perl/lib/CPANPLUS/Internals/Constants.pm        Mon May 28 
08:18:03 2007
+++ lib/CPANPLUS/Internals/Constants.pm Mon Sep  3 13:13:57 2007
@@ -115,10 +115,17 @@
                                                             'Makefile.PL' )
                                         : 'Makefile.PL';
                             };                   
-use constant MAKEFILE       => sub { return @_
+use constant MAKEFILE       => sub { my $makefile_name = 'Makefile';
+
+                                     # if VMS && MMK/MMS then DESCRIP.MMS
+                                     if (($^O eq 'VMS') &&
+                                        ($Config::Config{make} =~ /MM[S|K]/i)) 
{
+                                        $makefile_name = 'DESCRIP.MMS';
+                                     }
+                                     return @_
                                         ? File::Spec->catfile( @_,
-                                                            'Makefile' )
-                                        : 'Makefile';
+                                                            $makefile_name )
+                                        : $makefile_name;
                             }; 
 use constant BUILD_PL       => sub { return @_
                                         ? File::Spec->catfile( @_,

Reply via email to