On Sep 28, 2007, at 11:42 PM, Craig A. Berry wrote:
It applied cleanly against blead, where I've checked it in as 31995.
I wonder if we've had some drift between blead and the independent
version.
Indeed we have, here are the VMS-related outstanding differences.
Could someone verify that the blead version is correct, and let me
know who to assign credit to in the Changes file?
-Ken
diff -ur /Users/ken/Downloads/perl/bleadperl/lib/Module/Build/Base.pm
lib/Module/Build/Base.pm
--- /Users/ken/Downloads/perl/bleadperl/lib/Module/Build/Base.pm
2007-09-28 23:43:35.000000000 -0500
+++ lib/Module/Build/Base.pm 2007-09-28 20:57:28.000000000 -0500
@@ -447,7 +446,10 @@
my $exe = $c->get('exe_ext');
foreach my $thisperl ( @potential_perls ) {
- if (defined $exe and $proto->os_type ne 'VMS') {
+ if ($proto->is_vmsish) {
+ # VMS might have a file version at the end
+ $thisperl .= $exe unless $thisperl =~ m/$exe(;\d+)?$/i;
+ } elsif (defined $exe) {
$thisperl .= $exe unless $thisperl =~ m/$exe$/i;
}
diff -ur /Users/ken/Downloads/perl/bleadperl/lib/Module/Build/
Platform/VMS.pm lib/Module/Build/Platform/VMS.pm
--- /Users/ken/Downloads/perl/bleadperl/lib/Module/Build/Platform/
VMS.pm 2007-09-28 23:43:35.000000000 -0500
+++ lib/Module/Build/Platform/VMS.pm 2007-09-28 20:51:56.000000000 -0500
@@ -195,9 +195,8 @@
# Need to create with the same name as DynaLoader will load with.
if (defined &DynaLoader::mod2fname) {
- my $file = $$spec{module_name} . '.' . $self->{config}->get
('dlext');
- $file =~ tr/:/_/;
- $file = DynaLoader::mod2fname([$file]);
+ my $file = DynaLoader::mod2fname([$$spec{base_name}]);
+ $file .= '.' . $self->{config}->get('dlext');
$$spec{lib_file} = File::Spec->catfile($$spec{archdir}, $file);
}
@@ -220,36 +219,6 @@
return $result;
}
-=item dist_dir
-
-Inherit the standard version but replace embedded dots with
underscores because
-a dot is the directory delimiter on VMS.
-
-=cut
-
-sub dist_dir {
- my $self = shift;
-
- my $dist_dir = $self->SUPER::dist_dir;
- $dist_dir =~ s/\./_/g;
- return $dist_dir;
-}
-
-=item man3page_name
-
-Inherit the standard version but chop the extra manpage delimiter
off the front if
-there is one. The VMS version of splitdir('[.foo]') returns '', 'foo'.
-
-=cut
-
-sub man3page_name {
- my $self = shift;
-
- my $mpname = $self->SUPER::man3page_name( shift );
- my $sep = $self->manpage_separator;
- $mpname =~ s/^$sep//;
- return $mpname;
-}
=item expand_test_dir
@@ -275,9 +244,7 @@
=head1 AUTHOR
-Michael G Schwern <[EMAIL PROTECTED]>
-Ken Williams <[EMAIL PROTECTED]>
-Craig A. Berry <[EMAIL PROTECTED]>
+Michael G Schwern <[EMAIL PROTECTED]>, Ken Williams
<[EMAIL PROTECTED]>
=head1 SEE ALSO
