Nicholas Clark wrote:
On Thu, Jan 17, 2008 at 09:31:00AM -0600, Craig A. Berry wrote:
At 4:10 PM +0000 1/16/08, Nicholas Clark wrote:
I've made a 5.8.x snapshot.

http://www.ccl4.org/~nick/P/perl-32984.tar.bz2
(or http://www.ccl4.org/~nick/P/perl-32984.tar.gz )

I'm particularly curious how it fares on VMS,
@32985, here's what a default build gives me:

t/io/fs.....................................FAILED at test 5
lib/ExtUtils/t/cd...........................FAILED at test 1
lib/ExtUtils/t/eu_command...................FAILED at test 21
lib/Test/Harness/t/failure..................FAILED--expected test 3, saw test 2
lib/Test/Harness/t/strap-analyze............FAILED at test 37
lib/Test/Harness/t/test-harness.............FAILED at test 46
Failed 6 tests out of 1029, 99.42% okay.

If there are upgrades from CPAN in the pipeline for EU::MM and
Test::Harness, that will likely get us squared away with those.  I'll
see what I can figure out with io/fs.t.

Yes, there were. Now should be identical to 5.10 (apart from a $VERSION tweak)

$ diff -u t/io/fs.t ../../perl/t/io/fs.t --- t/io/fs.t Sat Nov 17 20:18:43 2007
+++ ../../perl/t/io/fs.t        Wed Sep 26 15:54:56 2007
@@ -58,6 +58,7 @@
 }
 elsif ($^O eq 'VMS') {
     `if f\$search("[.tmp]*.*") .nes. "" then delete/nolog/noconfirm 
[.tmp]*.*.*`;
+    `if f\$search("tmp.dir") .nes. "" then set file/prot=o:rwed tmp.dir;`;
     `if f\$search("tmp.dir") .nes. "" then delete/nolog/noconfirm tmp.dir;`;
     `create/directory [.tmp]`;
 }


That line is part of this, which I guess at the time I decided wasn't a
good thing to integrate to maint. (Right or wrong?)

This change is needed for VMS as by default directories are protected against delete access.

With out it, the delete/nolog command will likely fail, unless something else had explicitly set delete access on the directory.

I have not looked beyond this sample, but an alternative algorithm would not be to create the directory [.tmp] if it already existed.

When using the create/directory command, a protection can also be set to allow the directory to be deleted.

Change 27239 by [EMAIL PROTECTED] on 2006/02/20 09:31:03

        Subject: [EMAIL PROTECTED] vms glob/readdir/chdir EFS/long filename 
support
        From: John E. Malmberg <[EMAIL PROTECTED]>
        Date: Feb 20, 2006 3:43 AM
        Message-ID: <[EMAIL PROTECTED]>

Affected files ...

... //depot/perl/doio.c#322 edit
... //depot/perl/t/io/fs.t#59 edit
... //depot/perl/vms/vms.c#162 edit


Is the change to t/io/fs.t unrelated to the rest?

I am not sure.  It is required for t/io/fs.t to pass on VMS in anycase.


http://public.activestate.com/cgi-bin/perlbrowse/p/27239

-John
[EMAIL PROTECTED]
Personal Opinion Only

Reply via email to