Craig A. Berry wrote:

On Jan 22, 2009, at 9:03 AM, John Malmberg wrote:

Peter Prymmer wrote:



There is also some advice in the perlport.pod document:
 Don't count on filename globbing.  Use C<opendir>, C<readdir>, and
 C<closedir> instead.

Based on that, the Module::Build component that is using glob needs to be changed to use File::Glob::glob instead.


Adding this:

--- lib/Module/Build/Base.pm;-0 2009-01-14 11:50:10 -0600
+++ lib/Module/Build/Base.pm    2009-01-22 10:49:17 -0600
@@ -12,6 +12,7 @@ use Carp;
 use Cwd ();
 use File::Copy ();
 use File::Find ();
+use File::Glob ':globally';
 use File::Path ();
 use File::Basename ();
 use File::Spec 0.82 ();
[end]

does keep foo.PL from getting deleted, but overall changes the Module::Build score on VMS from:

Failed 3/28 test programs. 17/985 subtests failed.

to:

Failed 8/28 test programs. 36/985 subtests failed.

So that's clearly a step in the wrong direction. I'm working on alternatives.

I have submitted a number of patches to Module::Build and other modules that have not yet made it in to blead. Those may clear up some of the errors.

The issue is in Base.pm, on the line:

   foreach my $item (map glob($_), $self->cleanup) {

So replacing glob with File::Glob::glob may what is needed to fix things.

I will try that after my next test run completes.

-John
wb8...@gmail.com
Personal Opinion Only

Reply via email to