G'day Dave/Craig/p5p,
( This e-mail was written on a tram in Melbourne, without Internet access. )
Dave Mitchell wrote:
>> Thanks, Paul. That would be ok with me for 5.10.1, and I think would
>> just mean adding a clause to the Windows skippage that's already there.
>
> For 5.10.1, that sounds like the lowest risk option.
Done on my local autodie repo, with pushes to github and patches to Perl
soon. I can push a new release of autodie to the CPAN if that's likely to
make VMS folks happy.
However, it should be noted that the skip-list explicitly tests for 5.10.0
and earlier. My assumption is that this will be fixed in 5.10.1 because the
fix is *so* simple, and it's already in blead. From 079cb8cc:
--- a/lib/File/Copy.pm
+++ b/lib/File/Copy.pm
@@ -213,7 +213,7 @@ sub copy {
}
}
- return syscopy($from, $copy_to);
+ return syscopy($from, $copy_to) || 0;
}
There's no need to go mucking around in XS land, since we can easily convert
merely false values to zeros. This fixes it for both Windows, VMS, and any
other systems that have syscopy functions that don't adhere to the docs. It
also comes with a bundle of tests to make sure those four extra characters
do what they're supposed to.
If for any reason we don't go with the fix which is currently in blead, then
I think we should consider fixing the docs so that rather than File::Copy
saying it returns zero, it instead says that it returns false.
Cheerio,
Paul
--
Paul Fenwick <p...@perltraining.com.au> | http://perltraining.com.au/
Director of Training | Ph: +61 3 9354 6001
Perl Training Australia | Fax: +61 3 9354 2681
