On Wed, Aug 23, 2017 at 2:56 PM, Ole Troan <otr...@employees.org> wrote:
> Does that work for you?
Ole,
So, I have renamed SNAT --> NAT/NAT44 as needed now.
That's all fine.
Got caught by this failure mode, though....
I now have this code:
plugin_name = format(0, "nat_%08x%c", nat_api_version, 0);
base_msg_id = vl_client_get_first_plugin_msg_id((char *)plugin_name);
Which produced this failure:
vl_client_get_first_plugin_msg_id:500: plugin 'nat_72bb6883' not registered
But we renamed "snat" as "nat" for all the module names, etc., right?
Except this lingers in src/plugins/nat/nat_api.c:
snat_api_init (vlib_main_t * vm, snat_main_t * sm)
{
u8 *name;
clib_error_t *error = 0;
name = format (0, "snat_%08x%c", api_version, 0);
and correspondingly this in src/plugins/nat/nat_test.c:
name = format (0, "snat_%08x%c", api_version, 0);
Naturally, changing this is effectively the *real* commitment of the
rename effort, so it *could* be that this was a conscious choice to wait
until next release to do this particular name change.
I'm guessing there is no way to register both names ...
That's likely to be icky, right?
jdl
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
