> you can try to wrap that assert with #ifndef __COVERITY__ ... It is in a macro... I was thinking to do something like ASSERT(0 == (l) || (l) <= vec_max_len(v)) (with special care for not double-evaluating (l) ). But then, will the warning will disappear from Coverity? Or should we mark them anyway?
ben > > On 22 Oct 2019, at 16:22, Benoit Ganne (bganne) via Lists.Fd.Io > <bganne=cisco....@lists.fd.io> wrote: > > > > Hmm. Almost if not all of those are due to the newly introduced (by > me...) vec_set_len() macro https://gerrit.fd.io/r/c/vpp/+/21935 > > vec_reset_len() now use it, and setting len to 0 is always fine whatever > the vector length, so the ASSERT((l) <= vec_max_len(v)) in vec_set_len() > confuses Coverity. > > I am not familiar with the Coverity UI, but if we change the ASSERT() to > ignore the 0 case, will that silence Coverity? Or do we have to mark every > single report as a false positive? > > > > Ben > > > >> -----Original Message----- > >> From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Noreply > >> Jenkins > >> Sent: mardi 22 octobre 2019 16:04 > >> To: vpp-dev@lists.fd.io; Ed Kern (ejk) <e...@cisco.com> > >> Subject: [vpp-dev] Coverity run FAILED as of 2019-10-22 14:00:19 UTC > >> > >> Coverity run failed today. > >> > >> Current number of outstanding issues are 194 > >> Newly detected: 193 > >> Eliminated: 0 > >> More details can be found at https://scan.coverity.com/projects/fd-io- > >> vpp/view_defects > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > > > View/Reply Online (#14264): https://lists.fd.io/g/vpp-dev/message/14264 > > Mute This Topic: https://lists.fd.io/mt/36443369/675642 > > Group Owner: vpp-dev+ow...@lists.fd.io > > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com] > > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14269): https://lists.fd.io/g/vpp-dev/message/14269 Mute This Topic: https://lists.fd.io/mt/36443369/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
