> On 22 Oct 2019, at 19:26, Andrew 👽 Yourtchenko <ayour...@gmail.com> wrote: > > > Damjan, > > What impact will this have on attempts at automatic cherrypicks into > stable/1908 ?
No idea, never did automatic cherry-pick in my life. It sounds scary... > (And likewise, if it gets cherry-picked now into stable/1908, then will it > block a notable fraction of the past commits ?) > > If this is the only change, given the role the indent plays - maybe we could > rather get away with some creative use of sed oneliner after calling the > “new” indent ? I would not go there, if this change hurts automatic cherry-pick, lets forget it.... > > --a > >> On 22 Oct 2019, at 19:09, Damjan Marion via Lists.Fd.Io >> <dmarion=me....@lists.fd.io> wrote: >> >> >> Folks, >> >> Now we have 2nd release of ubuntu out which comes with new GNU indent which >> introduces lot of bug fixes. >> Unfortunately our repo is full of products of bugs which are fixed, so it >> results in big mess when new indent is used. >> >> Most of the time, it is about space after __attribute__ where one version >> thinks it should be, and another version thinks it should not. >> >> Up to the point where we come up with some solution, I would like to propose >> following change as workaround: >> >> https://gerrit.fd.io/r/c/vpp/+/22937 >> >> Thoughts? >> >> — >> Damjan >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> >> View/Reply Online (#14272): https://lists.fd.io/g/vpp-dev/message/14272 >> Mute This Topic: https://lists.fd.io/mt/36446352/675608 >> Group Owner: vpp-dev+ow...@lists.fd.io >> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [ayour...@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14274): https://lists.fd.io/g/vpp-dev/message/14274 Mute This Topic: https://lists.fd.io/mt/36446352/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
