> On 22 Oct 2019, at 20:06, Andrew Yourtchenko <ayour...@gmail.com> wrote: > > On 22 Oct 2019, at 19:42, Damjan Marion <dmar...@me.com > <mailto:dmar...@me.com>> wrote: > >> >> >>> On 22 Oct 2019, at 19:26, Andrew 👽 Yourtchenko <ayour...@gmail.com >>> <mailto:ayour...@gmail.com>> wrote: >>> >>>  >>> Damjan, >>> >>> What impact will this have on attempts at automatic cherrypicks into >>> stable/1908 ? >> >> No idea, never did automatic cherry-pick in my life. It sounds scary... > > > I meant the little joy of just pressing the “cherrypick” button and not > getting the conflicts :)
sounds manual to me :) > >> >> >>> (And likewise, if it gets cherry-picked now into stable/1908, then will it >>> block a notable fraction of the past commits ?) >>> >>> If this is the only change, given the role the indent plays - maybe we >>> could rather get away with some creative use of sed oneliner after calling >>> the “new” indent ? >> >> I would not go there, if this change hurts automatic cherry-pick, lets >> forget it.... > > I guess eventually we will be forced there - but, if Ubuntu 18.04 has the > correct version, maybe ok for now... Yep, until 20.04, which is next LTS release and comes in 6 months. I agree we will be forced to come up with some solution, but tbh I don't see sed as viable solution.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14279): https://lists.fd.io/g/vpp-dev/message/14279 Mute This Topic: https://lists.fd.io/mt/36446352/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
