Hi Paul, My only intent is to remove the randomness of mktemp: https://gerrit.fd.io/r/c/vpp/+/25973
/neale From: Paul Vinciguerra <[email protected]> Date: Wednesday 18 March 2020 at 02:11 To: "Klement Sekera -X (ksekera - PANTHEON TECH SRO at Cisco)" <[email protected]> Cc: "Neale Ranns (nranns)" <[email protected]>, vpp-dev <[email protected]> Subject: Re: [vpp-dev] Unit Test Results in Random directories I'm ok with a change, but are you thinking about setting the tempdir to a constant, or do you want to remove the unix { runtime-dir } option from the startup? On Tue, Mar 17, 2020 at 1:04 PM Klement Sekera via Lists.Fd.Io<http://Lists.Fd.Io> <[email protected]<mailto:[email protected]>> wrote: Hi Neale, When originally designing this, I opted in for `mktemp` as that’s the usual way to avoid clashes as at that time I assumed that this might be used on boxes where there are multiple users and they might like to run tests in parallel. At that time I didn’t expect issues like multiple vpps causing problems and it all kinda stuck. The way I deal with this is using `less /tmp/vpp-unittest-*/log.txt’ (which lately requires SANITY=no as it tends to pick log.txt from sanity run). For core I use DEBUG=core which gives me gdb without having to think about any of the paths. Having said all that, I don’t see any reason to keep random names. I’m not aware of any issues this change my cause… Regards, Klement > On 17 Mar 2020, at 17:56, Neale Ranns via Lists.Fd.Io<http://Lists.Fd.Io> > <[email protected]<mailto:[email protected]>> wrote: > > > Hi All, > > Am I the only one who finds the use of random directories for the unit-tests > an unnecessary annoyance? > > I would suggest that random names are not needed for security purposes, since > these files do not exist on a field system. Also, all directories are wiped > before the next test run so it can't be to support saving runs nor multiple > users. > > I find it annoying because I can't just reload log.txt or core in my editor > or debugger. > > It's a simple change if there's consensus, or you can just call me and old > grump and we can all move on __ > > /neale > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15809): https://lists.fd.io/g/vpp-dev/message/15809 Mute This Topic: https://lists.fd.io/mt/72029031/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
