Dirk wrote:
thanks for looking this up. I have changed a lot of code in the last days, so it is very possible that I broke something. Esp. the CRLF vs. LF changes are untested from my side, since I work only on windows. I don't have the problem here.
I would think based on what I heard from the SVN users list that you should because SVN stores "native" files always internally in LF format. After my last mail I did come to understand that the conversion should only happen for eol native files.
The CRLF to LF conversion is tied to the "svn:eol-style" property, and this property is only assigned due to auto-props. There is no implicit assignment from the converter itslef, like with the svn:mime-type property. Auto-props are only assigned in the ADD handler [1]: If I remeber this correctly, this was enough to set the property. The only problem was to emit an emty props block within the next revision. Since this will delete all assigned properties. Therefor the check in L845 [2] Your proposed change might work, and is in almost all cases propably the correct answer. But it is technically not correct since someone could specify a different svn:eol-style for non binary files in the auto-props. The correct solution would be to query each time for the auto-props and to check wether the eol-style is set.
Is it possible for someone to set eol-style but also a non-text mime-type? If so, should conversion take place? If not, then maybe both conditions should be checked, or when the autoprops are parsed the "sanity" is checked.
While thinking about that, it could also be possible that a rename could also change the properties.
Good catch.
What about the following patch?
I don't think you can comment out setting the props in the "add". I think also when rename occurs you have to possibly change props (something vss2svn has yet to do before?). In the patch as I see it you do the conversion right but the eol-style never actually makes it out to the dump file because it won't be in the $node and therefore not emitted by get_headers. Jason _______________________________________________ vss2svn-users mailing list Project homepage: http://www.pumacode.org/projects/vss2svn/ Subscribe/Unsubscribe/Admin: http://lists.pumacode.org/mailman/listinfo/vss2svn-users-lists.pumacode.org Mailing list web interface (with searchable archives): http://dir.gmane.org/gmane.comp.version-control.subversion.vss2svn.user
