Hello Jason:

I would think based on what I heard from the SVN users list that you
should because SVN stores "native" files always internally in LF format.
After my last mail I did come to understand that the conversion should
only happen for eol native files.
I based the patch on this mail from Aleksey: http://www.mail-archive.com/vss2svn-users@lists.pumacode.org/msg01036.html

The problem here is that the dump file is _required_ to only have the LF line terminators on files marked with svn:eol-style=native (see http://svn.haxx.se/dev/archive-2006-07/0981.shtml )

So it is completely up to you, to define your properties right. Before I made the auto-props change, we had always CRLF line endings on windows. And it wasn't a problem at all. It is only related to mixed environments, and only if you want to have the line-ending converted automatically (eol-style=native). There is no internal need on the storage format.


I don't think you can comment out setting the props in the "add".

this changed line wasn't in the _add_handler, but in the _rename_handler. I wasn't sure about the change, so I commented it out again.

I think also when rename occurs you have to possibly change props
(something vss2svn has yet to do before?). In the patch as I see it you
do the conversion right but the eol-style never actually makes it out to
the dump file because it won't be in the $node and therefore not emitted
by get_headers.
Sorry for the confusion. Adding the auto-properties is still there. But not for rename, yet.

Dirk

_______________________________________________
vss2svn-users mailing list
Project homepage:
http://www.pumacode.org/projects/vss2svn/
Subscribe/Unsubscribe/Admin:
http://lists.pumacode.org/mailman/listinfo/vss2svn-users-lists.pumacode.org
Mailing list web interface (with searchable archives):
http://dir.gmane.org/gmane.comp.version-control.subversion.vss2svn.user

Reply via email to