On Sat 05 Sep 2015, Emil Velikov wrote: > On 3 September 2015 at 21:27, Chad Versace <[email protected]> wrote:
> > Yes, I think this is worth doing. I prefer to see the cleanups arrive in > > this order, but it's not a strong preference: > > > > *. Fix bugs and leaks as they're discovered. > > 1. Replace waffle_test with cmocka. > > 2. Split `make check-func` into a separate target for each platform. > Considering the churn during the conversion, we might want to do it in > one step, namely: > 1. Update cmocka (fix integration, add missing include) > 2. Update existing users to cmocka 1.x > 3. Transition/refactor each platform to a separate cmocka based test > `gl_basic_test_$(platform)' > > > 3. Add `make check` and the GBM tests to some CI system. > I don't see any GBM tests in waffle. Am I missing something or you > have something locally ? I misspoke. I used to have GBM tests locally, but never pushed them because `make check-func` was not split per platform. So, that gives us a new task, to be done after refactoring "each platform to a separate cmocka based test": add some GBM tests. _______________________________________________ waffle mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/waffle
