Am Mittwoch, 1. November 2006 12:27 schrieb Gerard Krol: > Hi all, > > Attached are 2 sets of changes to remove some warnings. Those in > warnings_casts.patch cast variables back to what they were before the > binary operations, for example: > > - sVal.type = (*InstrPointer) & OPCODE_DATAMASK; > + sVal.type = (INTERP_TYPE)((*InstrPointer) & > OPCODE_DATAMASK); > > I think this is quite harmless. > warnings_changes.patch changes the types of some variables and adds > calls to keyCodeToSDLKey in some assert statements. A quick look-through told me that this looks good. (Especially the explanation helped a lot! Makes a difference if one is just blindly trying to silence the compiler or if he has good reasons to cast in specific places.) Will look at it further and test it later, probably on the WE.
--Dennis
pgpAQoYTCBGrB.pgp
Description: PGP signature
_______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
