[EMAIL PROTECTED] schreef: > On Sat, 09 Jun 2007 05:47:05 -0400 Freddie Witherden > <[EMAIL PROTECTED]> wrote: > >>> MSVC only supports C89 style variable declarations. >>> This means: Var decls are allowed at the beginning of the block only. >>> >> You're joking right? I am sure that when I used MSVC a while back it >> supported them, but I may have accidently been compiling as C++. I am >> positive though that it supports '//' comments, which are not in C89. >> Strange, very strange. >> > If all files were .cpp, then this no issue, it can handle most C99 ok. Since > .c, then MSVC is strict about most rules for C89, excep comments that begin > with //. > You mean that when compiled as C++ it handles C99 ? Well that's actually not true, it just handles C++ then, which just happens to have large similarities with C99. As for MSVC's C99 support (i.e. the support provided by the C compiler, not the C++ compiler) it barely has any. The only part I can think of are the one line comments really.
As for the patch itself, I don't mind moving just the variable declaration upwards. Moving the getDroidLevel(psDroid) invocation is different though. Especially since you move the comment above it as well, which does not only apply to that single function invocation. It also applies to the block below, your patch splits these two (i.e. the getDroidLevel invocation and the block) apart and splits them by a statement that's unrelated to the comment (actualDamage = damage - armour). So instead of your patch I've simply declared the variable at the beginning of the block and initialize it later in r1485. -- Giel
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
