Is there any reason we are not going by the 'rules' we discussed before? I thought we had decided that any 'major' (or even minor--though, I think minor is a bit of a waste) patch that could break something or change a ton of files, we would stick in trac, and then let it sit there a few days for people to comment about them?
Or is it because Trac is not relaying the tickets to the WZ-dev list that is the problem? It seems some patches that were applied were done rather quickly, without some comments on just what (or why) it was done. Revision: 6634 -- [snip] - I don't think I screwed up start-at-block-declaration rules for MSVC, but given the size of these changes I can't be sure. [snip] Well you did. Though, at least nobody can say you aren't verbose enough in the logs to see what is going on. ;) Revision: 6617 -- Bump copyright While that don't bother me as much, it just seems it could have been put off a bit while the other issues are worked out. It just is a PITA to revert back to a version prior to this. (I guess, git people have no issues about that?) Revision: 6616 -- need to respect 8-char filename limits, be clear in naming instead When you do this stuff, *please* elaborate what you are doing exactly. The project/solution, and codeblocks (.cbp) needs to be edited. I can handle the MSVC stuff, so I don't got a real problem with that, it is just I need to know *what* exactly got changed, without falling back to reading the .am files. Revision: 6615 -- Move piefixedpoint.h and pievector.h out of ivis, since they are quite generic A bit better, but *where* did they go now? (see above) Revision: 6614 -- Move endian_* functions into a dedicated header and do not include it from frame.h *Where* and *why* the change ? Revision: 6613 -- Move files which extend a c std library header to a filename of similar name Extension functions dealing with ... * strings are in string_ext.h * stdio (namely printf variants) are in stdio_ext.h * math are in math_ext.h These headers are no longer included by frame.h ---------- Oh good, a longer comment. :) Too bad this *really* breaks MSVC. http://developer.wz2100.net/ticket/257 Sorry for picking on these commits, I don't mean to piss you guys off, since I rather have commits than no commits. :) I was just under the impression that we were going to go by the rules for committing, which was why we had the other discussion about 'rules' before right? Or to recap, please be more verbose on what you are changing, and *why* you are changing something. If you don't think that belongs in the commit log, then please make a ticket. It also is a bit easier to change the changelog from reading svn log, and not reading the persons brain--Nexus isn't at 100% yet. /me back this weekend to here the flames against this post. :) p.s. don't do too many changes to cheat.c, netplay.* , multi*, I got patches in trac, and not in trac that need to go in. _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
