Hello Buggy! ... and hello List! Am Donnerstag, 12. Februar 2009 06:34:07 schrieb bugs buggy: > I thought we had decided that any 'major' (or even minor--though, I > think minor is a bit of a waste) patch that could break something or > change a ton of files, we would stick in trac, and then let it sit > there a few days for people to comment about them? It just seems that no one is commenting anyway on most of those...
And this also depends on a subjective opinion on what is "major". I.e. I would not have assumed that all those of my changes where "major". (Yes, I admit that some are...) > Revision: 6617 -- Bump copyright > > While that don't bother me as much, it just seems it could have been > put off a bit while the other issues are worked out. It just is a > PITA to revert back to a version prior to this. (I guess, git people > have no issues about that?) I just changes one line at the very beginning of the file... I doubt that it interferes with any change anyone made... (And even if, the merge strategy should be obvious.) > Revision: 6616 -- need to respect 8-char filename limits, be clear in > naming instead Actually the quote is wrong. "*no longer* need"... > When you do this stuff, *please* elaborate what you are doing exactly. > The project/solution, and codeblocks (.cbp) needs to be edited. Forgot about that, can try myself on the codeblocks file. > I > can handle the MSVC stuff, so I don't got a real problem with that, it > is just I need to know *what* exactly got changed, without falling > back to reading the .am files. I was under the impression that SVN would show that in the commitlog, just as Git does... I can add that info next time. > Revision: 6615 -- Move piefixedpoint.h and pievector.h out of ivis, > since they are quite generic > > A bit better, but *where* did they go now? (see above) lib/framework (see above for next time) > Revision: 6614 -- Move endian_* functions into a dedicated header and > do not include it from frame.h > > *Where* and *why* the change ? They are used just in very few places. Additionally I wanted to get frame.h slick, because it is included virtually anywhere. > Revision: 6613 -- > Move files which extend a c std library header to a filename of similar > name > > Too bad this *really* breaks MSVC. > http://developer.wz2100.net/ticket/257 See my comment there. > Or to recap, please be more verbose on what you are changing, and > *why* you are changing something. If you don't think that belongs in > the commit log, then please make a ticket. Will do, just thought the "what" was obvious from the log already. > It also is a bit easier to change the changelog from reading svn log, > and not reading the persons brain--Nexus isn't at 100% yet. There was no user visible change, so there should no need to write it into the changelog. > /me back this weekend to here the flames against this post. :) No flaming here please. Greetings, DevU
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
