On 2/14/10, Per Inge Mathisen <[email protected]> wrote: > On Sun, Feb 14, 2010 at 7:02 AM, <[email protected]> wrote: > > Revision: 9800 > > > http://warzone2100.svn.sourceforge.net/warzone2100/?rev=9800&view=rev > > Author: buginator > > Date: 2010-02-14 06:02:27 +0000 (Sun, 14 Feb 2010) > > > > Log Message: > > ----------- > > Thy creator creates (r8069) and now I must show him the inevitable. > > Reset your keymaps, debug mode enabled, select thy subject and hit left > shift delete :) > > > This is the silliest commit I have seen in a long time. It deserves > some kind of award. > > First, the commit message is nonsensical. > > Second, the code seems a total duplicate of kf_KillSelected.
Yes, some odd reason, I never noticed this before. As for the commit message, see below. > Third, breaking the keymap is completely unnecessary. There are > several unused entries called "kf_NOOP" that are reserved for adding > new entries without breaking keymap compatibility. You can also add > new entries at the end of the list to reduce breakage. noted for future > Fourth, this should have been posted to trac before being committed. > That would probably have prevented 2-3 above. > > I am reverting this for now. I would have reverted, and yeah, (in hindsight ) it should have been in trac, I'll chalk it up to late night (lack of) decision making skills gone haywire. Sleep is good, lack of sleep turns you silly, and that is what this commit was. :( Apologies to all.... this will not happen again. :s _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
