[ 
https://issues.apache.org/jira/browse/WAVE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175171#comment-13175171
 ] 

[email protected] commented on WAVE-313:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3296/
-----------------------------------------------------------

Review request for wave.


Summary
-------

Implements suggestions in WAVE-313:
- Adds a hideRegistration option to the server config file
- Removes the auth/registration route when this is the case
- Adds a RegistrationRobot to let the admin user always create new users

Know limitations/features:
- Doesn't remove any 'register' links - server 404s when they are clicked.
- Manually created users don't get WelcomeBot'd


This addresses bug WAVE-313.
    https://issues.apache.org/jira/browse/WAVE-313


Diffs
-----

  /server-config.xml 1213039 
  /server.config.example 1213039 
  /src/org/waveprotocol/box/server/CoreSettings.java 1213039 
  /src/org/waveprotocol/box/server/ServerMain.java 1213039 
  /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 
  
/src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/3296/diff


Testing
-------

Compiled + run. Tried to access auth/register with hideRegistration=false and 
hideRegistration=true.
Logged in as the admin user and tried to create new accounts with the 
RegistrationRobot - then logged into new accounts to check valid.


Thanks,

Ali


                
> option to disable "register new user" on web frontend, possibility for 
> admin-user to add manually new users
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WAVE-313
>                 URL: https://issues.apache.org/jira/browse/WAVE-313
>             Project: Wave
>          Issue Type: New Feature
>          Components: Web Client
>            Reporter: JGB
>            Assignee: Ali Lown
>            Priority: Minor
>              Labels: features
>
> As today, when you set up a new Wave-in-a-box-Server, everyone who has access 
> to the web Client can create a new user. I think, there are a lot of people 
> who would like to create private Wave-Server, so it would be nice to have an 
> option to disable the "register new users"-site. As a consequence of this, 
> there should also be the possibility to register as admin-user manually new 
> accounts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to