[
https://issues.apache.org/jira/browse/WAVE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175305#comment-13175305
]
[email protected] commented on WAVE-313:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3296/#review4097
-----------------------------------------------------------
/src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
<https://reviews.apache.org/r/3296/#comment9218>
It seems like there's white space
/src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
<https://reviews.apache.org/r/3296/#comment9219>
Please remove whitespace
/src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
<https://reviews.apache.org/r/3296/#comment9220>
It seems like user registration is an important event, so it might be a
good idea to add some mechanism to register a listener on a new user
registration - Similar to RobotRegistrar. But it can be done it other patch as
well.
/src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
<https://reviews.apache.org/r/3296/#comment9222>
Would be nice to add a test for this method.
/src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java
<https://reviews.apache.org/r/3296/#comment9216>
Can we adjust the comment for Registration Robot?
- Yuri
On 2011-12-22 23:52:27, Ali Lown wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3296/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-22 23:52:27)
bq.
bq.
bq. Review request for wave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implements suggestions in WAVE-313:
bq. - Adds a hideRegistration option to the server config file
bq. - Removes the auth/registration route when this is the case
bq. - Adds a RegistrationRobot to let the admin user always create new users
bq.
bq. Know limitations/features:
bq. - Doesn't remove any 'register' links - server 404s when they are clicked.
bq. - Manually created users don't get WelcomeBot'd
bq.
bq.
bq. This addresses bug WAVE-313.
bq. https://issues.apache.org/jira/browse/WAVE-313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /server-config.xml 1213039
bq. /server.config.example 1213039
bq. /src/org/waveprotocol/box/server/CoreSettings.java 1213039
bq. /src/org/waveprotocol/box/server/ServerMain.java 1213039
bq. /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
1213039
bq.
/src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3296/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Compiled + run. Tried to access auth/register with hideRegistration=false
and hideRegistration=true.
bq. Logged in as the admin user and tried to create new accounts with the
RegistrationRobot - then logged into new accounts to check valid.
bq.
bq.
bq. Thanks,
bq.
bq. Ali
bq.
bq.
> option to disable "register new user" on web frontend, possibility for
> admin-user to add manually new users
> -----------------------------------------------------------------------------------------------------------
>
> Key: WAVE-313
> URL: https://issues.apache.org/jira/browse/WAVE-313
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: JGB
> Assignee: Ali Lown
> Priority: Minor
> Labels: features
>
> As today, when you set up a new Wave-in-a-box-Server, everyone who has access
> to the web Client can create a new user. I think, there are a lot of people
> who would like to create private Wave-Server, so it would be nice to have an
> option to disable the "register new users"-site. As a consequence of this,
> there should also be the possibility to register as admin-user manually new
> accounts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
