[
https://issues.apache.org/jira/browse/WAVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209190#comment-13209190
]
[email protected] commented on WAVE-317:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3882/#review5157
-----------------------------------------------------------
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11265>
Construct -> Constructs
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11266>
I think it would be better to add @Nullable annotation on the parameter
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11267>
an vector -> the array
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11268>
@throws InvalidParticipantAddress if at least one of the addresses failed
validation.
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11264>
I think it would be better to put this logic into a static util class, or
even just a static method in ParticipantController. The logic of building a
list of participants from a string with optional default domain is relevant
mostly for client side, and not generic enough to be put inside ParticipantId
class.
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11261>
Please add spaces
int i=0;i<addressList.length;i++
->
int i = 0; i < addressList.length; i++
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11262>
Seems like this check can be done outside of the loop.
src/org/waveprotocol/wave/model/wave/ParticipantId.java
<https://reviews.apache.org/r/3882/#comment11263>
Please remove empty line
test/org/waveprotocol/wave/model/wave/ParticipantIdTest.java
<https://reviews.apache.org/r/3882/#comment11272>
Please makes sure we follow consistent indentation
test/org/waveprotocol/wave/model/wave/ParticipantIdTest.java
<https://reviews.apache.org/r/3882/#comment11269>
Please add spaces before and after all arithmetical operators.
test/org/waveprotocol/wave/model/wave/ParticipantIdTest.java
<https://reviews.apache.org/r/3882/#comment11271>
Why using compareTo instead of equals?
test/org/waveprotocol/wave/model/wave/ParticipantIdTest.java
<https://reviews.apache.org/r/3882/#comment11270>
Please fix indentation.
- Yuri
On 2012-02-15 22:54:41, rocklund wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3882/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-15 22:54:41)
bq.
bq.
bq. Review request for wave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented as suggested in the jira-issue as a client side implementation
in ParticipantController.java. I selected the separator for the multiple
participant list to be semi-colon(;).
bq.
bq.
bq. This addresses bug wave-317.
bq. https://issues.apache.org/jira/browse/wave-317
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java
ec9e25a
bq. src/org/waveprotocol/wave/model/wave/ParticipantId.java a5dbdf6
bq. test/org/waveprotocol/wave/model/wave/ParticipantIdTest.java 58a2772
bq.
bq. Diff: https://reviews.apache.org/r/3882/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Compiled and run.
bq.
bq. * Tested to add single as well as multiple participants
bq. * Tested to add participants both with and without @localhost
bq. * Tested to add invalid participants
bq.
bq.
bq. Thanks,
bq.
bq. rocklund
bq.
bq.
> Allow adding (copy/pasting) multiple participants into a wave
> -------------------------------------------------------------
>
> Key: WAVE-317
> URL: https://issues.apache.org/jira/browse/WAVE-317
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Yuri Zelikov
> Priority: Minor
> Labels: StarterProject
>
> I think it would be nice to allow to paste/enter multiple participant ids
> separated by comma into the "add participant" dialog box. The list will be
> parsed/validated by the client and interpreted like it the user added these
> participants one by one. This way it would be easier to create waves with
> multiple participants.
> The code is handled in ParticipantController.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
