[
https://issues.apache.org/jira/browse/WAVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209633#comment-13209633
]
[email protected] commented on WAVE-317:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3882/
-----------------------------------------------------------
(Updated 2012-02-16 19:19:37.700527)
Review request for wave.
Changes
-------
Thanks for the reviews. Updated according to the comments:
* Fixed indentation
* Added spaces in between arithmetical operations
* Updated to use equals instead of compareTo in unit test
* Moved the buildParticipantList method to the ParticipantController
* Moved the unit tests to the new class ParticipantControllerTest.java
* Added @Nullable annotation to localDomain
@Yuri: I don't understand how you mean that I can move the localDomain
null-check outside of the for-loop? The current address processed in the
for-loop is handled differently depending on the result of that null-check.
Summary
-------
Implemented as suggested in the jira-issue as a client side implementation in
ParticipantController.java. I selected the separator for the multiple
participant list to be semi-colon(;).
This addresses bug wave-317.
https://issues.apache.org/jira/browse/wave-317
Diffs (updated)
-----
src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java
ec9e25a
test/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantControllerTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3882/diff
Testing
-------
Compiled and run.
* Tested to add single as well as multiple participants
* Tested to add participants both with and without @localhost
* Tested to add invalid participants
Thanks,
rocklund
> Allow adding (copy/pasting) multiple participants into a wave
> -------------------------------------------------------------
>
> Key: WAVE-317
> URL: https://issues.apache.org/jira/browse/WAVE-317
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Yuri Zelikov
> Priority: Minor
> Labels: StarterProject
>
> I think it would be nice to allow to paste/enter multiple participant ids
> separated by comma into the "add participant" dialog box. The list will be
> parsed/validated by the client and interpreted like it the user added these
> participants one by one. This way it would be easier to create waves with
> multiple participants.
> The code is handled in ParticipantController.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
