[
https://issues.apache.org/jira/browse/WAVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215201#comment-13215201
]
[email protected] commented on WAVE-319:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3960/
-----------------------------------------------------------
(Updated 2012-02-23 23:30:04.244231)
Review request for wave.
Changes
-------
Getting closer to a real implementation now. The two major points to get done
before done is unit testing and JSON loading of gadget info.
This is updated in this version:
* Created a new utility function in PositionUtil for calculating the maximum
height for a popup to fit the screen and updated CenterPopupPositioner to use
this new function
* Updated the GadgetInfoProvider to handle filtering
* Updated the GadgetSelectorWidget to use the filtering in the
GadgetInfoProvider
* Polished the UI of the popup to look as it is suppose to
* Listening to enter event on the gadget url TextBox as well
Summary
-------
* Added more gadgets to the gadget list
* Made the gadget list scrollable and filterable through a text box and a drop
down box for categories.
* The filtering looks at both the name of the gadget and its description.
Author could also be added as a searchable property (?)
* Filter the result directly in the scrollable gadget list
* Marking the top filtered search as selected with gray background and made it
possible to choose that gadget by pressing enter
* Change the default focus to the filter box to allow the user to quickly
select a gadget from the list by filter it out and pressing enter
Note: The code is Not ready yet. Adding the patch for you to review the new
functionality. I am willing to reconsider and of my implementation choices
above if there is better alternatives. This is some things I plan to do with
the code before I consider it to be ready:
* Rewrite GadgetInfoProvider to read from a JSON file and preferably handle
filtering
* Write unit tests for the GadgetInfoProvider class.
* Rewrite the GadgetInfo and GadgetInfoWidget handling in GadgetSelectorWidget
* Make the popup more beautifully layouted
* Clean up line endings, indentations and stuff
This addresses bug wave-319.
https://issues.apache.org/jira/browse/wave-319
Diffs (updated)
-----
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProvider.java
PRE-CREATION
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.java
97611b4
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.ui.xml
c8b7a81
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
ccbcdae
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml
cc6b73e
src/org/waveprotocol/wave/client/widget/popup/CenterPopupPositioner.java
555f32e
src/org/waveprotocol/wave/client/widget/popup/PositionUtil.java 5e3bab4
Diff: https://reviews.apache.org/r/3960/diff
Testing
-------
Tested locally. Have not tested all the added gadgets yet though.
Thanks,
rocklund
> Improve the "Add gadget" popup
> -------------------------------
>
> Key: WAVE-319
> URL: https://issues.apache.org/jira/browse/WAVE-319
> Project: Wave
> Issue Type: Improvement
> Components: Web Client
> Reporter: Yuri Zelikov
> Assignee: Olof
> Priority: Minor
> Labels: StarterProject
>
> Improve the "Add gadget" popup. Currently it contains only a handful of
> gadgets. Add more gadget definitions, make the panel scrollable, add ability
> to filter the gadgets list and or add suggestion box -
> http://gwt.google.com/samples/Showcase/Showcase.html#!CwSuggestBox
> The gadget definitions can be taken from http://goo.gl/nEem2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
