[
https://issues.apache.org/jira/browse/WAVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223117#comment-13223117
]
[email protected] commented on WAVE-319:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3960/#review5635
-----------------------------------------------------------
Great progress! Thanks for doing this.
Some comments below.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
<https://reviews.apache.org/r/3960/#comment12268>
Can we just extract this code into a method with corresponding name instead
of adding comment? Also for code/comments below. It always better to write self
documenting code. If there's some code that requires a comment - usually it
means that this snippet can be extracted into a method of it's own.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
<https://reviews.apache.org/r/3960/#comment12269>
No need for adding too much comments if the code is self descriptive like
in this case.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/JsonGadgetInfo.java
<https://reviews.apache.org/r/3960/#comment12270>
How about to make this list available on the server side? We can add a
servlet that will read the json file and server it to the client. This way
adding a new gadget definition will be as simple as editing json formatted file.
test/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProviderTest.java
<https://reviews.apache.org/r/3960/#comment12271>
Empty line.
- Yuri
On 2012-03-04 22:32:02, rocklund wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3960/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-04 22:32:02)
bq.
bq.
bq. Review request for wave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. * Added more gadgets to the gadget list
bq. * Made the gadget list scrollable and filterable through a text box and a
drop down box for categories.
bq. * The filtering looks at both the name of the gadget and its description.
Author could also be added as a searchable property (?)
bq. * Filter the result directly in the scrollable gadget list
bq. * Marking the top filtered search as selected with gray background and
made it possible to choose that gadget by pressing enter
bq. * Change the default focus to the filter box to allow the user to quickly
select a gadget from the list by filter it out and pressing enter
bq.
bq.
bq. This addresses bug wave-319.
bq. https://issues.apache.org/jira/browse/wave-319
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProvider.java
PRE-CREATION
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.java
97611b4
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.ui.xml
c8b7a81
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
ccbcdae
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml
cc6b73e
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/JsonGadgetInfo.java
PRE-CREATION
bq. src/org/waveprotocol/wave/client/widget/popup/CenterPopupPositioner.java
555f32e
bq. src/org/waveprotocol/wave/client/widget/popup/PositionUtil.java 5e3bab4
bq.
test/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProviderTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3960/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally.
bq. Successfully run all junit test (Except
PerUserWaveViewSubscriberTest::testGetPerUserWaveView and
WaveServerTest::testWaveletNotification that fails even before this patch)
bq. Tested all included gadgets
bq.
bq.
bq. Thanks,
bq.
bq. rocklund
bq.
bq.
> Improve the "Add gadget" popup
> -------------------------------
>
> Key: WAVE-319
> URL: https://issues.apache.org/jira/browse/WAVE-319
> Project: Wave
> Issue Type: Improvement
> Components: Web Client
> Reporter: Yuri Zelikov
> Assignee: Olof
> Priority: Minor
> Labels: StarterProject
>
> Improve the "Add gadget" popup. Currently it contains only a handful of
> gadgets. Add more gadget definitions, make the panel scrollable, add ability
> to filter the gadgets list and or add suggestion box -
> http://gwt.google.com/samples/Showcase/Showcase.html#!CwSuggestBox
> The gadget definitions can be taken from http://goo.gl/nEem2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
