Yuri, I think this is a good start. I think we should get some comments from the thread and then post this up to the web site in the getting involved section. A couple things I would add are:
- The use of @Override. - Under optimization, if dealing with loops or iteration evaluate the growth rate of the function (Big-O notation). - Conformance to style standards ~Michael On Mar 31, 2011, at 3:38 AM, Yuri Z wrote: > Hello Apache Wave developers > I have compiled for myself a checklist for items that I need to check before > sending a patch for review. It is not an official guide, but merely my > private checklist that I made in the effort to minimize the amount of > comments that my patches receive. Every item in the checklist originated > from a comment by reviewer. So I thought that maybe other developers would > find it useful too. > You are also welcome to review the checklist and fix it or add new items at > GDocs: > https://docs.google.com/document/d/16bkaVFajA-845q4bOCDiK3yXhqCWqFBjYANw04Bq0bg/edit?hl=en&authkey=CPPztdwP# > > Yuri