El 22/10/11 01:14, Nelson Silva escribió:
> Great, it LGTM but i won't be able to try it until next week.
> Just a couple of remarks (sorry for not using Review Board but i'm using my
> phone now) :
> 
> Are the changes to PasswordRobot.java necessary?

I think so, because it's related with the new jetty/servlet version.

> Perhaps we could use socket.io.js's WS.check() since it also prevents from
> detecting the Flash version of WebSocket.

Now I'm using window.websocket as Thomas suggested.

> P.S: My Review Board username is nelson.silva

Added...

Bests,

-- 
Vicente

Reply via email to