----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review4536 -----------------------------------------------------------
Great, thanks! But I think we need to move further and fully merge the Wave Import code into WIAB. 1. If you think that some jars should be updated/added to the WIAB third_party dependencies - please do it. 2. Your code makes use of AppEngine related classes as the means for URL fetching etc... There's no need to use them in WIAB, we can use just regular JEE classes. 3. The same regarding file system access - no need to uses services provided by AppEngine (and simulated for use in Dev environments). I have a suggestion - maybe as the first step you will submit as patch only the files that you wanted to be in WIAB anyway? I mean the ImportServlet? This way people will be able to use WaveImport and WIAB binary distributions without any need for manual code altering. - Yuri On 2012-01-23 08:51:37, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > ----------------------------------------------------------- > > (Updated 2012-01-23 08:51:37) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > The implementation is very raw, due to time constraints. > Import accesses special service on the Wiab. > Authorization on import service are not implemented now. > To access GWave was used Walkaround with GAE libraries. > Later, when GWave stop, this module can be used to export/import waves of > Wiab. > Then Walkaround and GAE libraries may be excluded from the distribution. > Imports of attachments not yet implemented. > Also, there is no generation of wave Id's for import into a non-empty store, > and from different domains. > Instructions for use enclosed in the file README. > GIT repository https://github.com/jorkey/WaveImport. > > > Diffs > ----- > > ./import/build.properties PRE-CREATION > ./import/build.xml PRE-CREATION > ./import/run-export.sh PRE-CREATION > ./import/run-import.sh PRE-CREATION > ./import/src/waveimport/WaveExport.java PRE-CREATION > ./import/src/waveimport/WaveImport.java PRE-CREATION > ./import/third_party/libs/appengine-api-stubs.jar UNKNOWN > ./import/third_party/libs/appengine-api.jar UNKNOWN > ./import/third_party/libs/appengine-local-runtime.jar UNKNOWN > ./import/third_party/libs/communication.jar UNKNOWN > ./import/third_party/libs/google-api-client-1.5.0-beta.jar UNKNOWN > ./import/third_party/libs/google-http-client-1.5.0-beta.jar UNKNOWN > ./import/third_party/libs/google-http-client-extensions-1.5.0-beta.jar > UNKNOWN > ./import/third_party/libs/google-oauth-client-1.5.0-beta.jar UNKNOWN > ./import/third_party/libs/guava-10.0.1.jar UNKNOWN > ./import/third_party/libs/javax.inject.jar UNKNOWN > ./import/third_party/src/org/apache/google/walkaround/proto/Diff.java > PRE-CREATION > ./import/third_party/src/org/apache/google/walkaround/proto/Extensions.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/proto/GoogleImport.java > PRE-CREATION > ./import/third_party/src/org/apache/google/walkaround/proto/Proto.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/proto/RobotSearchDigest.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/proto/RobotSearchDigestUtil.java > PRE-CREATION > ./import/third_party/src/org/apache/google/walkaround/proto/Walkaround.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/proto/gson/RobotSearchDigestGsonImpl.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/proto/impl/RobotSearchDigestImpl.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/util/server/MonitoringVars.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/util/server/RetryHelper.java > PRE-CREATION > ./import/third_party/src/org/apache/google/walkaround/util/server/Util.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/util/server/flags/FlagDeclaration.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/util/server/flags/FlagFormatException.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/util/server/flags/JsonFlags.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/DatastoreProvider.java > PRE-CREATION > ./import/third_party/src/org/apache/google/walkaround/wave/server/Flag.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/FlagConfiguration.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/FlagName.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/StoreType.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/auth/NeedNewOAuthTokenException.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/auth/OAuthCredentials.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/auth/OAuthRequestHelper.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/auth/OAuthedFetchService.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/auth/StableUserId.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/auth/UserContext.java > PRE-CREATION > > ./import/third_party/src/org/apache/google/walkaround/wave/server/googleimport/RobotApi.java > PRE-CREATION > ./src/org/waveprotocol/box/server/ServerMain.java 1233510 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3564/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
