----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review4667 -----------------------------------------------------------
./README.import <https://reviews.apache.org/r/3564/#comment10411> Are you sure it should be Web application? I think it should be "desktop" application ./README.import <https://reviews.apache.org/r/3564/#comment10412> Probably need to mention to run first ant dist-import ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java <https://reviews.apache.org/r/3564/#comment10384> Can we make the delay configurable? Probably on some systems 10ms won't be enough? ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java <https://reviews.apache.org/r/3564/#comment10386> Please put in block ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java <https://reviews.apache.org/r/3564/#comment10397> I think this method should return true only for [email protected]. Probably there should other method like isUnknownParticipant() that would return true for all the rest that end with @a.gwave.com ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10401> Can we extract the lines 150-157 into a method? createAuthorizedRobotApi()? ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10400> oauth_service -> oauthService ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10404> There's no need for this check inside the double for, I think we can push it up. Also, I think it would be more efficient to use HashedSet class for the included/excluded wave ids, as it is more efficient for looking up a value. ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10402> Line too long. ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10398> raw_deltas -> rawDeltas ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10403> raw_deltas -> rawDeltas ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10399> Probably you can use here FileUtils.waveletIdToPathSegment and FileUtils.waveIdToPathSegment instead of manually crafting the file names. ./src/org/waveprotocol/box/waveimport/WaveExport.java <https://reviews.apache.org/r/3564/#comment10405> static private - > private static ./src/org/waveprotocol/box/waveimport/google/RobotApi.java <https://reviews.apache.org/r/3564/#comment10406> Line too long. ./src/org/waveprotocol/box/waveimport/google/RobotApi.java <https://reviews.apache.org/r/3564/#comment10407> Line too long ./src/org/waveprotocol/box/waveimport/google/RobotApi.java <https://reviews.apache.org/r/3564/#comment10408> Line too long ./src/org/waveprotocol/box/waveimport/google/RobotApi.java <https://reviews.apache.org/r/3564/#comment10409> Line too long ./src/org/waveprotocol/box/waveimport/google/RobotApi.java <https://reviews.apache.org/r/3564/#comment10410> Line too long - Yuri On 2012-01-28 04:58:44, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > ----------------------------------------------------------- > > (Updated 2012-01-28 04:58:44) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > The implementation is very raw, due to time constraints. > Import accesses special service on the Wiab. > Authorization on import service are not implemented now. > Imports of attachments not yet implemented. > Also, there is no generation of wave Id's for import into a non-empty store, > and from different domains. > Instructions for use enclosed in the file README.import. > > > Diffs > ----- > > ./README.import PRE-CREATION > ./build.properties 1236970 > ./build.xml 1236970 > ./run-export.sh PRE-CREATION > ./run-import.sh PRE-CREATION > ./src/org/waveprotocol/box/server/ServerMain.java 1236970 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveExport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveImport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotApi.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/google-import.proto > PRE-CREATION > > ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java > PRE-CREATION > ./third_party/runtime/google_client/COPYING PRE-CREATION > ./third_party/runtime/google_client/google-api-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google_client/google-http-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google_client/google-oauth-client-1.5.0-beta.jar > UNKNOWN > > Diff: https://reviews.apache.org/r/3564/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
