----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3709/#review4739 -----------------------------------------------------------
Can we break it into 3 patches and code reviews? - Yuri On 2012-01-31 21:47:45, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3709/ > ----------------------------------------------------------- > > (Updated 2012-01-31 21:47:45) > > > Review request for wave, Yuri Zelikov and Lennard de Rijk. > > > Summary > ------- > > This is a few minor changes based on user feedback from my server. > > - Makes the WIAB logo on the client page link back to the domain root (like > every other website on the internet) > - Lets the find-next-unread-blip focusNext method try previous in the event > there aren't any more down the wave (gets hooked into the "Next Unread" > button and the "Spacebar" shortcut). This is because the users never found > the Shift-Space equivalent, and once told they didn't understand why the 2 > functions had been separated. > - Swaps the "Next" and "Previous" buttons on ViewToolbar because the ordering > seemed strange. > > > Diffs > ----- > > /src/org/waveprotocol/box/server/gxp/TopBar.gxp 1237143 > /src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java > 1237143 > /src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java > 1237143 > /src/org/waveprotocol/box/server/waveserver/QueryHelper.java 1237143 > /src/org/waveprotocol/box/server/waveserver/TokenQueryType.java 1237143 > /src/org/waveprotocol/box/server/waveserver/Wave.java 1237143 > /src/org/waveprotocol/box/server/waveserver/WaveMap.java 1237143 > /src/org/waveprotocol/box/server/waveserver/WaveServerModule.java 1237143 > /src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java > 1237143 > > /src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java > 1237143 > /src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/ViewToolbar.java > 1237143 > /test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java > 1237143 > > /test/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriberTest.java > 1237143 > /test/org/waveprotocol/box/server/waveserver/WaveDigesterTest.java 1237143 > /test/org/waveprotocol/box/server/waveserver/WaveMapTest.java 1237143 > > Diff: https://reviews.apache.org/r/3709/diff > > > Testing > ------- > > Compiled + tested each function locally, by clicking icon/buttons and > pressing spacebar. > > > Thanks, > > Ali > >
