Just making sure, this would not break attachments viewed from another wave server via federation, right? That is, does the link, when viewed from another server, point to the server with the file rather than using the relative path?
I have not looked at the code (on my phone atm, and I am not sure I would understand it regardless), but came to mind as a potential problem. I apologize if I am bringing up something that has already been dealt with. —Zachary “Gamer_Z.” Yaro On Feb 3, 2012 6:18 AM, "Yuri Zelikov" <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3753/ > ----------------------------------------------------------- > > Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. > > > Summary > ------- > > Make attachment links URL be relative instead of absolute - that should > allow for attachment link to work even if the domain address changed. > > > This addresses bug WAVE-330. > https://issues.apache.org/jira/browse/WAVE-330 > > > Diffs > ----- > > src/org/waveprotocol/wave/client/doodad/link/Link.java f5fb0e4 > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java > 73a6cfc > > Diff: https://reviews.apache.org/r/3753/diff > > > Testing > ------- > > Added attachment and verified that it can be downloaded. > > > Thanks, > > Yuri > >
