> On 2012-02-17 20:52:41, Michael MacFadden wrote: > > Was this committed?
No, someone mentioned that this fix won't work with federation. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3753/#review5198 ----------------------------------------------------------- On 2012-02-03 11:18:36, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3753/ > ----------------------------------------------------------- > > (Updated 2012-02-03 11:18:36) > > > Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. > > > Summary > ------- > > Make attachment links URL be relative instead of absolute - that should allow > for attachment link to work even if the domain address changed. > > > This addresses bug WAVE-330. > https://issues.apache.org/jira/browse/WAVE-330 > > > Diffs > ----- > > src/org/waveprotocol/wave/client/doodad/link/Link.java f5fb0e4 > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java > 73a6cfc > > Diff: https://reviews.apache.org/r/3753/diff > > > Testing > ------- > > Added attachment and verified that it can be downloaded. > > > Thanks, > > Yuri > >
