Yuri, I see that you committed my SSL patches to the repo after testing them. That is fine, but the committed changes will only work in Chrome with websockets. I did state in the original review message that this adjusted socket-io jar would also need to be comitted (Firefox/non-websockets browsers).
The jar is attached to an earlier message in this thread, and simply forces a toggle of the 'secure' option based on the document.location reported from the browser. You will probably want to push this too. Thanks. Ali On Jan 22, 2012 10:59 PM, "Ali Lown" <[email protected]> wrote: > Sent a review request for most of the code. > To get socket.io to work correctly though I had to edit socket.io.js > in the third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT.jar > (attached here for your reference). > > As for the issue of privileged ports, I have chosen to run WIAB on a > non-privileged, and with the help of an iptables REDIRECT, can make it > appear to be running on 443. > > Works for me. :) > > On 18 January 2012 15:12, Vicente J. Ruiz Jurado <[email protected]> > wrote: > > El 18/01/12 00:20, Ali Lown escribió: > >> I had a go at setting it up and yes this method of adjusting jetty > >> seems to work fine. > >> > >> Over the next couple of days I will have a go at writing a patch so > >> that we can choose between ssl (and normal) listeners, keystore > >> location and password all from the configuration file. > > > > Just to say: Great job guys! > > >
