-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3564/#review5020
-----------------------------------------------------------
Hi Andrew.
We are almost there - just few more fixes :)
1. Please update the diff with the latest changes in the code - I am getting
merge conflicts in CoreSettings.java and server-config.xml.
2. Please rename third_party/google-client folder to
third_party/google-api-client
3. Add README file to third_party/google-api-client - you can use README from
third_party/runtime/commons_lang as template.
4. Add the jars in third_party/google-api-client to the classpath (the
.classpath file)
5. Please update config.server.example and add a template for ENABLE_IMPORT
option, something like this:
# Enable import of waves via /import URL. Default value: false
enable_import = @ENABLE_IMPORT@
./build.xml
<https://reviews.apache.org/r/3564/#comment11022>
Insert empty line
./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java
<https://reviews.apache.org/r/3564/#comment11075>
This test is failing - please fix.
- Yuri
On 2012-02-09 08:30:08, Andrew Kaplanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3564/
> -----------------------------------------------------------
>
> (Updated 2012-02-09 08:30:08)
>
>
> Review request for wave and Yuri Zelikov.
>
>
> Summary
> -------
>
> Exports waves from GWave to files, and imports them to Wiab by two command
> line utilities.
> Import accesses special service on the Wiab.
> Imports of attachments not yet implemented.
> Also, there is no generation of wave Id's for import into a non-empty store,
> and from different domains.
> Instructions for use enclosed in the file README.import.
>
>
> Diffs
> -----
>
> ./third_party/runtime/google_client/google-api-client-1.5.0-beta.jar
> UNKNOWN
> ./third_party/runtime/google_client/google-http-client-1.5.0-beta.jar
> UNKNOWN
> ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java
> PRE-CREATION
> ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java
> PRE-CREATION
> ./third_party/runtime/google_client/COPYING PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java
> PRE-CREATION
>
> ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java
> PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/google/RobotApi.java PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/WaveImport.java PRE-CREATION
> ./src/org/waveprotocol/box/waveimport/WaveExport.java PRE-CREATION
> ./build.properties 1240026
> ./build.xml 1240026
> ./run-export.sh PRE-CREATION
> ./run-import.sh PRE-CREATION
> ./server-config.xml 1240026
> ./src/org/waveprotocol/box/server/CoreSettings.java 1240026
> ./src/org/waveprotocol/box/server/ServerMain.java 1240026
> ./src/org/waveprotocol/box/server/util/testing/TestingConstants.java
> 1240026
> ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java
> PRE-CREATION
> ./README.import PRE-CREATION
> ./third_party/runtime/google_client/google-oauth-client-1.5.0-beta.jar
> UNKNOWN
>
> Diff: https://reviews.apache.org/r/3564/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>
