> On 2012-02-13 06:52:27, Yuri Zelikov wrote: > > Hi Andrew. > > We are almost there - just few more fixes :) > > 1. Please update the diff with the latest changes in the code - I am > > getting merge conflicts in CoreSettings.java and server-config.xml. > > 2. Please rename third_party/google-client folder to > > third_party/google-api-client > > 3. Add README file to third_party/google-api-client - you can use README > > from third_party/runtime/commons_lang as template. > > 4. Add the jars in third_party/google-api-client to the classpath (the > > .classpath file) > > 5. Please update config.server.example and add a template for ENABLE_IMPORT > > option, something like this: > > # Enable import of waves via /import URL. Default value: false > > enable_import = @ENABLE_IMPORT@ > >
done > On 2012-02-13 06:52:27, Yuri Zelikov wrote: > > ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java, line > > 98 > > <https://reviews.apache.org/r/3564/diff/10/?file=73803#file73803line98> > > > > This test is failing - please fix. Works Ok from me. > On 2012-02-13 06:52:27, Yuri Zelikov wrote: > > ./build.xml, line 662 > > <https://reviews.apache.org/r/3564/diff/10/?file=73782#file73782line662> > > > > Insert empty line done for all targets - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review5020 ----------------------------------------------------------- On 2012-02-13 08:09:43, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > ----------------------------------------------------------- > > (Updated 2012-02-13 08:09:43) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > Import accesses special service on the Wiab. > Imports of attachments not yet implemented. > Also, there is no generation of wave Id's for import into a non-empty store, > and from different domains. > Instructions for use enclosed in the file README.import. > > > Diffs > ----- > > ./.classpath 1243425 > ./README.import PRE-CREATION > ./build.properties 1243425 > ./build.xml 1243425 > ./run-export.sh PRE-CREATION > ./run-import.sh PRE-CREATION > ./server-config.xml 1243425 > ./server.config.example 1243425 > ./src/org/waveprotocol/box/server/CoreSettings.java 1243425 > ./src/org/waveprotocol/box/server/ServerMain.java 1243425 > ./src/org/waveprotocol/box/server/util/testing/TestingConstants.java > 1243425 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveExport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveImport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotApi.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java > PRE-CREATION > > ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java > PRE-CREATION > ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > PRE-CREATION > ./third_party/runtime/google-api-client/COPYING PRE-CREATION > ./third_party/runtime/google-api-client/README PRE-CREATION > ./third_party/runtime/google-api-client/google-api-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google-api-client/google-http-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google-api-client/google-oauth-client-1.5.0-beta.jar > UNKNOWN > > Diff: https://reviews.apache.org/r/3564/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
