----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/#review5278 -----------------------------------------------------------
Checked the patch - great progress! - Yuri On 2012-02-19 17:08:12, rocklund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3960/ > ----------------------------------------------------------- > > (Updated 2012-02-19 17:08:12) > > > Review request for wave. > > > Summary > ------- > > * Added more gadgets to the gadget list > * Made the gadget list scrollable and filterable through a text box and a > drop down box for categories. > * The filtering looks at both the name of the gadget and its description. > Author could also be added as a searchable property (?) > * Filter the result directly in the scrollable gadget list > * Marking the top filtered search as selected with gray background and made > it possible to choose that gadget by pressing enter > * Change the default focus to the filter box to allow the user to quickly > select a gadget from the list by filter it out and pressing enter > > > Note: The code is Not ready yet. Adding the patch for you to review the new > functionality. I am willing to reconsider and of my implementation choices > above if there is better alternatives. This is some things I plan to do with > the code before I consider it to be ready: > > * Rewrite GadgetInfoProvider to read from a JSON file and preferably handle > filtering > * Write unit tests for the GadgetInfoProvider class. > * Rewrite the GadgetInfo and GadgetInfoWidget handling in GadgetSelectorWidget > * Make the popup more beautifully layouted > * Clean up line endings, indentations and stuff > > > This addresses bug wave-319. > https://issues.apache.org/jira/browse/wave-319 > > > Diffs > ----- > > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProvider.java > PRE-CREATION > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.java > 97611b4 > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.ui.xml > c8b7a81 > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java > ccbcdae > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml > cc6b73e > src/org/waveprotocol/wave/client/widget/popup/CenterPopupPositioner.java > 555f32e > > Diff: https://reviews.apache.org/r/3960/diff > > > Testing > ------- > > Tested locally. Have not tested all the added gadgets yet though. > > > Thanks, > > rocklund > >
