-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3960/
-----------------------------------------------------------
(Updated 2012-03-11 17:31:31.929113)
Review request for wave.
Changes
-------
Thanks for your nice feedback Juri!
I updated according to your comments. Still have two things to do:
* Update GadgetInfoProvider to interface as you suggested
* Add proper error handling
Then I wondering if I am doing the correct file handling of the json file?
* Should I create some kind of FileStore for the file and place it in a
sub-folder or is it ok to have it in the server root?
* Should the GadgetProviderServlet save the content of the file into a memory
variable (String) for later use or should it read the content from the file
every time?
Thanks.
Summary
-------
* Added more gadgets to the gadget list
* Made the gadget list scrollable and filterable through a text box and a drop
down box for categories.
* The filtering looks at both the name of the gadget and its description.
Author could also be added as a searchable property (?)
* Filter the result directly in the scrollable gadget list
* Marking the top filtered search as selected with gray background and made it
possible to choose that gadget by pressing enter
* Change the default focus to the filter box to allow the user to quickly
select a gadget from the list by filter it out and pressing enter
This addresses bug wave-319.
https://issues.apache.org/jira/browse/wave-319
Diffs (updated)
-----
jsongadgets.json PRE-CREATION
src/org/waveprotocol/box/server/ServerMain.java 13a2d55
src/org/waveprotocol/box/server/rpc/GadgetProviderServlet.java PRE-CREATION
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProvider.java
PRE-CREATION
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.java
97611b4
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.ui.xml
c8b7a81
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
ccbcdae
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml
cc6b73e
src/org/waveprotocol/wave/client/widget/popup/CenterPopupPositioner.java
555f32e
src/org/waveprotocol/wave/client/widget/popup/PositionUtil.java 5e3bab4
test/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProviderTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3960/diff
Testing
-------
Tested locally.
Successfully run all junit test (Except
PerUserWaveViewSubscriberTest::testGetPerUserWaveView and
WaveServerTest::testWaveletNotification that fails even before this patch)
Tested all included gadgets
Thanks,
rocklund
