> On 2012-04-20 16:21:12, Ali Lown wrote: > > The diff is fine. > > > > Did you test the built-in robots (passwd-bot, etc.)? If they still work > > then LGTM.
Yes, checked them too. Robots should be fine as long as they don't do manual wave id parsing and use up to date client library. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4828/#review7075 ----------------------------------------------------------- On 2012-04-20 12:49:04, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4828/ > ----------------------------------------------------------- > > (Updated 2012-04-20 12:49:04) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Summary > ------- > > Changes WaveId representation to the modern style: using '/' as separator > instead of '!'. This is required for consistency as most of the WIAB already > uses the modern '/' separator while the Robot API still returns old waveId > representation. > The change might break some robots that were built for WIAB, but I don't > think there are too many yet. > > > Diffs > ----- > > src/com/google/wave/api/ApiIdSerializer.java 674f235 > src/org/waveprotocol/wave/model/id/WaveId.java 45c0d6f > > Diff: https://reviews.apache.org/r/4828/diff > > > Testing > ------- > > Checked that all test pass. > Verified the web client works. > > > Thanks, > > Yuri > >
