> On 2012-04-23 14:47:28, maze wrote:
> > This change broke our existing waves. After logging in, the inbox stayed 
> > empty and the following stack trace was immediately shown (replaced our 
> > domain with xxx.com):
> > 
> > Token:  1335192295655
> >  Class$NXf: Invalid id 'xxx.com/w+QAyhGJwY_YA': Wave id must be of the form 
> > <domain>!<id>
> >   Unknown.WF (Unknown source:0)
> >   Unknown.cG (Unknown source:0)
> >   Unknown.KWb (Unknown source:0)
> >   Unknown.CYf (Unknown source:0)
> >   Unknown.Jqc (Unknown source:0)
> >   Unknown.Kqc (Unknown source:0)
> >   Unknown.Gqc (Unknown source:0)
> > Caused by: Token:  1335192295655
> >  Invalid id 'xxx.com/w+QAyhGJwY_YA': Wave id must be of the form 
> > <domain>!<id>
> >   Unknown.WF (Unknown source:0)
> >   Unknown.PXf (Unknown source:0)
> >   Unknown.UXf (Unknown source:0)
> >   Unknown.CYf (Unknown source:0)
> >   Unknown.Jqc (Unknown source:0)
> >   Unknown.Kqc (Unknown source:0)
> >   Unknown.Gqc (Unknown source:0)
> > 
> > 
> > I had to revert the changes in order get our waves back. We have no special 
> > robots or gadgets in use. 
> > 
> > Is this intended? Is there a way to "migrate" the old style waves?
> 
> Yuri Zelikov wrote:
>     Did you try to clean the browser cache?
> 
> maze wrote:
>     Tried deleting the cache. Didn't help (Chrome, Firefox and Linux). Also 
> tried on a Windows system and in a clean browser.
>     
>     We can at least view some of the waves when visiting the direct url 
> (/#xxx.com/w+xxxxx). The inbox stays empty though, with the error message 
> still there. Maybe only one or a few waves are broken?
> 
> maze wrote:
>     Maybe I should add that we had imported some waves from Google Wave into 
> our server. We were using the WaveImport branch 
> (https://github.com/jorkey/WaveImport) at that time.
> 
> Yuri Zelikov wrote:
>     I just checked again and it works fine for me. Maybe you didn't recompile 
> the client?
>     please try the following:
>     ant clean compile-gwt dist-server
>     and the try to run the server again and clean the browser cache.

Shame on me, I didn't compile-gwt.. Now it works!

Sorry for bothering you. Thanks, Yuri!


- maze


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4828/#review7130
-----------------------------------------------------------


On 2012-04-20 12:49:04, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4828/
> -----------------------------------------------------------
> 
> (Updated 2012-04-20 12:49:04)
> 
> 
> Review request for wave, Michael MacFadden and Ali Lown.
> 
> 
> Summary
> -------
> 
> Changes WaveId representation to the modern style: using '/' as separator 
> instead of '!'. This is required for consistency as most of the WIAB already 
> uses the modern '/' separator while the Robot API still returns old waveId 
> representation.
> The change might break some robots that were built for WIAB, but I don't 
> think there are too many yet.
> 
> 
> Diffs
> -----
> 
>   src/com/google/wave/api/ApiIdSerializer.java 674f235 
>   src/org/waveprotocol/wave/model/id/WaveId.java 45c0d6f 
> 
> Diff: https://reviews.apache.org/r/4828/diff
> 
> 
> Testing
> -------
> 
> Checked that all test pass.
> Verified the web client works.
> 
> 
> Thanks,
> 
> Yuri
> 
>

Reply via email to