----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4937/#review7386 -----------------------------------------------------------
src/org/waveprotocol/box/server/gxp/TopBar.gxp <https://reviews.apache.org/r/4937/#comment16296> Should the default state read 'Saved?'. This would be displayed whilst the rest of the code was setting up the client panel, and so there wouldn't be any status at this stage. So, I think this should be left blank at startup. src/org/waveprotocol/wave/client/StageTwo.java <https://reviews.apache.org/r/4937/#comment16297> Think we might want this class in the review as well, since it doesn't seem to already exist at src/org/waveprotocol/box/webclient/client/ - Ali On 2012-04-30 20:18:18, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4937/ > ----------------------------------------------------------- > > (Updated 2012-04-30 20:18:18) > > > Review request for wave, Michael MacFadden, Christian Ohler, and Ali Lown. > > > Summary > ------- > > Adds saved state indicator. The idea was mainly borrowed from Walkaround. The > indicator displays the wavelet state to provide the user with more detailed > information about the state of saved deltas than just merely the network > status. In fact, it is possible that the network status will display "online" > while some deltas still not saved. > > > Diffs > ----- > > src/org/waveprotocol/box/server/gxp/TopBar.gxp 13cc1b3 > src/org/waveprotocol/box/webclient/client/StageTwoProvider.java 7725298 > src/org/waveprotocol/box/webclient/client/StagesProvider.java 04ffd49 > src/org/waveprotocol/box/webclient/client/WebClient.java c87b7cc > src/org/waveprotocol/wave/client/StageTwo.java 58ddb60 > > Diff: https://reviews.apache.org/r/4937/diff > > > Testing > ------- > > Tested on local WIAB instance. > > > Thanks, > > Yuri > >
