> On 2012-04-30 20:27:37, Ali Lown wrote: > > src/org/waveprotocol/box/server/gxp/TopBar.gxp, line 42 > > <https://reviews.apache.org/r/4937/diff/1/?file=105493#file105493line42> > > > > Should the default state read 'Saved?'. This would be displayed whilst > > the rest of the code was setting up the client panel, and so there wouldn't > > be any status at this stage. > > > > So, I think this should be left blank at startup.
With blank it will look like: "[email protected] | | Online | Sign Out" The extra pipe looks weird. I think Saved status is still correct even when loading, as everything is saved. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4937/#review7386 ----------------------------------------------------------- On 2012-04-30 20:34:13, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4937/ > ----------------------------------------------------------- > > (Updated 2012-04-30 20:34:13) > > > Review request for wave, Michael MacFadden, Christian Ohler, and Ali Lown. > > > Summary > ------- > > Adds saved state indicator. The idea was mainly borrowed from Walkaround. The > indicator displays the wavelet state to provide the user with more detailed > information about the state of saved deltas than just merely the network > status. In fact, it is possible that the network status will display "online" > while some deltas still not saved. > > > Diffs > ----- > > src/org/waveprotocol/box/server/gxp/TopBar.gxp 13cc1b3 > src/org/waveprotocol/box/webclient/client/SavedStateIndicator.java > PRE-CREATION > src/org/waveprotocol/box/webclient/client/StageTwoProvider.java 7725298 > src/org/waveprotocol/box/webclient/client/StagesProvider.java 04ffd49 > src/org/waveprotocol/box/webclient/client/WebClient.java c87b7cc > src/org/waveprotocol/wave/client/StageTwo.java 58ddb60 > > Diff: https://reviews.apache.org/r/4937/diff > > > Testing > ------- > > Tested on local WIAB instance. > > > Thanks, > > Yuri > >
