----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5256/#review8174 -----------------------------------------------------------
Looks fine, but it seems like the patch fails to apply to the tip. - Yuri On 2012-05-29 11:08:12, Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5256/ > ----------------------------------------------------------- > > (Updated 2012-05-29 11:08:12) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Summary > ------- > > This patch addresses: > https://issues.apache.org/jira/browse/WAVE-352 > adding a new configuration parameter, so we can configure and increase the > size of messages in websocket. > > > Diffs > ----- > > server-config.xml ddfc669 > server.config.example cf8aeb1 > src/org/waveprotocol/box/server/CoreSettings.java 3df1eae > src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 65367c3 > > Diff: https://reviews.apache.org/r/5256/diff > > > Testing > ------- > > The paste of a wikipedia article like: > http://en.wikipedia.org/wiki/Apache_Wave > in a wave now works without disconnections and data lost. > > > Thanks, > > Vicente J. > >
