> On 2012-05-29 17:27:17, Yuri Zelikov wrote:
> > Looks fine, but it seems like the patch fails to apply to the tip.

The patch is updated. We have tested in kune.cc and works perfect.


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5256/#review8174
-----------------------------------------------------------


On 2012-05-30 07:58:19, Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5256/
> -----------------------------------------------------------
> 
> (Updated 2012-05-30 07:58:19)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Summary
> -------
> 
> This patch addresses:
> https://issues.apache.org/jira/browse/WAVE-352
> adding a new configuration parameter, so we can configure and increase the 
> size of messages in websocket.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/CoreSettings.java d9b95ec 
>   src/org/waveprotocol/box/server/ServerModule.java a28faa2 
>   src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 65367c3 
>   server-config.xml 5f39312 
>   server.config.example 0d3da67 
> 
> Diff: https://reviews.apache.org/r/5256/diff
> 
> 
> Testing
> -------
> 
> The paste of a wikipedia article like:
> http://en.wikipedia.org/wiki/Apache_Wave
> in a wave now works without disconnections and data lost.
> 
> 
> Thanks,
> 
> Vicente J.
> 
>

Reply via email to