----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5388/#review8342 -----------------------------------------------------------
src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java <https://reviews.apache.org/r/5388/#comment17987> Do we really need the focus to be static? It seems like it should be instance field. Anyway, I don't think the EditSession should be directly aware of FocusFramePresenter. Can we register a listener for edit events that will activate the switching of the style? src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.css <https://reviews.apache.org/r/5388/#comment17990> Why orange? Is it consistent with WIAB color scheme? - Yuri Zelikov On June 18, 2012, 1:44 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5388/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 1:44 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > One usability problem that is commonly reported is that it's not clear when > we are editing a blip or not. This patch try to address this issue > highlighting with a different color the blip while is being edited. > > I think that this helps to the compression of wave by the general public a > little bit. > > Note: I don't have IE so I cannot suggest similar css changes for this. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > df9357a > > src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java > fe5b163 > src/org/waveprotocol/wave/client/wavepanel/view/FocusFrameView.java b5dfb87 > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.css > 5742922 > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.java > fe83889 > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.ui.xml > e2795e6 > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrameIE.ui.xml > ddcbc59 > > Diff: https://reviews.apache.org/r/5388/diff/ > > > Testing > ------- > > Normal edition of blips > > > Thanks, > > Vicente J. Ruiz Jurado > >
