----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5388/#review9785 -----------------------------------------------------------
Ship it! LGTM. Committed as r1368705. - Yuri Zelikov On Aug. 2, 2012, 11:43 a.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5388/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2012, 11:43 a.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > One usability problem that is commonly reported is that it's not clear when > we are editing a blip or not. This patch try to address this issue > highlighting with a different color the blip while is being edited. > > I think that this helps to the compression of wave by the general public a > little bit. > > Note: I don't have IE so I cannot suggest similar css changes for this. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java > c21e19b > > src/org/waveprotocol/wave/client/wavepanel/impl/focus/BlipEditStatusListener.java > PRE-CREATION > > src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusFramePresenter.java > fe5b163 > src/org/waveprotocol/wave/client/wavepanel/view/FocusFrameView.java b5dfb87 > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.css > 5742922 > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.java > fe83889 > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.ui.xml > e2795e6 > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrameIE.ui.xml > ddcbc59 > > Diff: https://reviews.apache.org/r/5388/diff/ > > > Testing > ------- > > Normal edition of blips > > > Thanks, > > Vicente J. Ruiz Jurado > >
