----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5375/#review9783 -----------------------------------------------------------
Great patch! Just minor comments. src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java <https://reviews.apache.org/r/5375/#comment20773> Please terminate the comment with full stop. src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java <https://reviews.apache.org/r/5375/#comment20770> Please put the line after if inside block -> {} server-config.xml <https://reviews.apache.org/r/5375/#comment20777> Please change it to "${http_frontend_public_address}" so it will default to the same value as http_frontend_public_address. src/org/waveprotocol/box/server/rpc/WaveClientServlet.java <https://reviews.apache.org/r/5375/#comment20776> I think there's no need for this conditional assignment, just address the comment in server-config.xml. - Yuri Zelikov On Aug. 2, 2012, 10:16 a.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5375/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2012, 10:16 a.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > The idea is that the client uses two configurable listening addresses: > - one for the normal traffic (all the common server petitions), the current > http_frontend_public_address > - and a new one for the websocket traffic (that can be configured to a > different subdomain or port if it's necessary). > > That is, we would be able to split these two different traffics. This would > allow the use of proxies, caches or CDNs for the "normal traffic". > > Issue: > https://issues.apache.org/jira/browse/WAVE-357 > > > Diffs > ----- > > server-config.xml f55e440 > server.config.example 02b27bc > src/org/waveprotocol/box/server/CoreSettings.java e95a920 > src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp cea296a > src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 82c3c8d > src/org/waveprotocol/box/server/rpc/WaveClientServlet.java f8a95f2 > src/org/waveprotocol/box/webclient/client/WebClient.java b16df98 > > Diff: https://reviews.apache.org/r/5375/diff/ > > > Testing > ------- > > Tested with different ports/subdomains, for example with this in /etc/hosts > as websocket domain > 127.0.0.1 ws.localhost > but also tested in a production server. > > > Thanks, > > Vicente J. Ruiz Jurado > >
