----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5375/#review10910 -----------------------------------------------------------
Ship it! LGTM Committed as r1379094. - Yuri Zelikov On Aug. 3, 2012, 8:47 a.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5375/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 8:47 a.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > The idea is that the client uses two configurable listening addresses: > - one for the normal traffic (all the common server petitions), the current > http_frontend_public_address > - and a new one for the websocket traffic (that can be configured to a > different subdomain or port if it's necessary). > > That is, we would be able to split these two different traffics. This would > allow the use of proxies, caches or CDNs for the "normal traffic". > > Issue: > https://issues.apache.org/jira/browse/WAVE-357 > > > Diffs > ----- > > server-config.xml f55e440 > server.config.example 02b27bc > src/org/waveprotocol/box/server/CoreSettings.java e95a920 > src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp cea296a > src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 82c3c8d > src/org/waveprotocol/box/server/rpc/WaveClientServlet.java f8a95f2 > src/org/waveprotocol/box/webclient/client/WebClient.java b16df98 > > Diff: https://reviews.apache.org/r/5375/diff/ > > > Testing > ------- > > Tested with different ports/subdomains, for example with this in /etc/hosts > as websocket domain > 127.0.0.1 ws.localhost > but also tested in a production server. > > > Thanks, > > Vicente J. Ruiz Jurado > >
