> On Aug. 8, 2012, 8:16 p.m., Yuri Zelikov wrote:
> > I am not sure how to test it - seems like WAVE-363 prevents the digests 
> > from updating and displaying the "zero" date.

I test it via ant waveharness-hosted (because the dates there are 1970 at the 
start-up). This patch only affects the time of the blips.


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6339/#review10035
-----------------------------------------------------------


On Aug. 3, 2012, 12:04 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6339/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 12:04 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> This patch does not set the time in blips when the date is 1970. From 
> WAVE-181:
> 
> "The cause is that the existing c/s protocol has no timestamp for document 
> updates (but does for snapshots)."
> 
> 
> This addresses bug WAVE-181.
>     https://issues.apache.org/jira/browse/WAVE-181
> 
> 
> Diffs
> -----
> 
>   
> src/org/waveprotocol/wave/client/wavepanel/render/UndercurrentShallowBlipRenderer.java
>  1521736 
>   
> src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java
>  45f074b 
> 
> Diff: https://reviews.apache.org/r/6339/diff/
> 
> 
> Testing
> -------
> 
> Test ant waveharness-hosted
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>

Reply via email to