> On Aug. 9, 2012, 11:30 a.m., Ali Lown wrote: > > Since there wasn't any response to my message in the mailing list > > responding to this review: > > > > I don't feel that simply hiding the time is really a good solution for this. > > How about showing the time that the delta was received by the client in > > this situation (since it would be pretty close to the 'true time the delta > > was resolved'. > > The client would then report the 'true time' when the wave is next reloaded. > > > > By hiding the time it will be awkward to determine the order of blips > > (since my usage patterns with wave, do not make any assumptions about the > > more recent blips being further down).
Actually I agree with Ali - I feel like hiding the problem is not right. We better try to solve the issue instead of hiding it. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6339/#review10064 ----------------------------------------------------------- On Aug. 3, 2012, 12:04 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6339/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 12:04 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > This patch does not set the time in blips when the date is 1970. From > WAVE-181: > > "The cause is that the existing c/s protocol has no timestamp for document > updates (but does for snapshots)." > > > This addresses bug WAVE-181. > https://issues.apache.org/jira/browse/WAVE-181 > > > Diffs > ----- > > > src/org/waveprotocol/wave/client/wavepanel/render/UndercurrentShallowBlipRenderer.java > 1521736 > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java > 45f074b > > Diff: https://reviews.apache.org/r/6339/diff/ > > > Testing > ------- > > Test ant waveharness-hosted > > > Thanks, > > Vicente J. Ruiz Jurado > >
