> On May 14, 2012, 7:51 p.m., Ali Lown wrote: > > Whilst there is nothing wrong with this code, it doesn't feel like a good > > way of handling announcements (since it can only be set at server boot > > time). > > Yuri Zelikov wrote: > Yeah, I know. Still better than nothing.
ping. Just want to emphasize, that the announcement is optional. - Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5114/#review7861 ----------------------------------------------------------- On May 14, 2012, 7:40 p.m., Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5114/ > ----------------------------------------------------------- > > (Updated May 14, 2012, 7:40 p.m.) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Description > ------- > > Adds ability to display announcement on the top bar. > > > Diffs > ----- > > server-config.xml ddfc669 > server.config.example cf8aeb1 > src/org/waveprotocol/box/server/CoreSettings.java 3df1eae > src/org/waveprotocol/box/server/gxp/TopBar.gxp a7a53ff > src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 921979b > > Diff: https://reviews.apache.org/r/5114/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Yuri Zelikov > >
