----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5114/#review11203 -----------------------------------------------------------
Ship it! Looks good to me, but I couldn’t test without a rebase. In the future we can find a way to force the server reload this property without restarting (trapping a signal or opening a administrative port or similar). - Vicente J. Ruiz Jurado On May 14, 2012, 7:40 p.m., Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5114/ > ----------------------------------------------------------- > > (Updated May 14, 2012, 7:40 p.m.) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Description > ------- > > Adds ability to display announcement on the top bar. > > > Diffs > ----- > > server-config.xml ddfc669 > server.config.example cf8aeb1 > src/org/waveprotocol/box/server/CoreSettings.java 3df1eae > src/org/waveprotocol/box/server/gxp/TopBar.gxp a7a53ff > src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 921979b > > Diff: https://reviews.apache.org/r/5114/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Yuri Zelikov > >
